[PATCH libdrm v3 1/3] drmSL: Fix neighbor lookup

Emil Velikov emil.l.velikov at gmail.com
Thu Mar 26 07:53:50 PDT 2015


On 24/03/15 23:16, Jan Vesely wrote:
> Commit e4a519635f75bde38aeb5b09f2ff4efbf73453e9:
>     Tidy up compile warnings by cleaning up types.
> 
> removed call to SLLocate which gutted the function of all functionality.
> This patch restores the original behavior, with an additional fix
> that zeros the update array in case SLLocate bails early.
> 
> v2: zero the update array instead of checking the return value.
>     SLLocate returns NULL both on failure and if the element is greater
>     than everything in the list
> v3: Improve commit message
> 
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> Acked-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
> sorry for spamming, just realized it might be a good idea co CC the original
> author and committer.
> 
> This was broken since 2.4.18 (2010). I guess it's safe to say that nobody
> uses it. What are the policies on removing parts of API?
> 
Either nobody uses it or nobody which uses it cases enough to report/fix
it. Either way I think that people prefer to be cautious and do API
cleanups alongside a major bump of the library.

-Emil



More information about the dri-devel mailing list