[PATCH] xf86drmMode.h: inline -> __inline for use with gcc -std=c89 -pedantic

randyf at sibernet.com randyf at sibernet.com
Thu Mar 26 09:57:50 PDT 2015


>
>> Alternatively can we:
>>  (1) move the wrapper to xf86drmMode.h itself, or
>>  (2) move this inline helper function out of xf86drmMode.h and into
>> the two libdrm tests that use it (or a shared test helper .h [0])
>>  (3) remove the inline and make drm_property_type_is a non-inline
>> function in xf86drmMode.c
>>
>> [0] I think Thierry already has a patch set that rearranges the tests
>> to use some shared headers.  Perhaps this will work well once his set
>> lands.
>>
> Fwiw I would opt for 1 or 3 (leaning towards 1), as 2 might lead to:
> - Everyone coming up with their own "helper", or
> - Ignoring DRM_MODE_PROP_EXTENDED_TYPE checking
> drmModePropertyPtr::flags, thus causing all sorts of chaos.
>
>
> Randy, Niveditha, Stuart,
>
> Does the compiler(s) used to build libdrm and friends support __inline ?

   It should.  I can't be 100% sure as there was just recently a new 
compiler release, but I would also suspect if this support was broken or 
dropped, then lots of stuff would break.


   Cheers!

 	---- Randy


More information about the dri-devel mailing list