[PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer

Inki Dae inki.dae at samsung.com
Thu Mar 26 18:55:47 PDT 2015


Hi Daniel,

On 2015년 03월 26일 23:48, Daniel Stone wrote:
> Hi Inki,
> 
> On Thu, 26 Mar, 2015 at 2:32 PM, Inki Dae <inki.dae at samsung.com> wrote:
>> Applied.
> 
> Thanks very much.
> 
>> Could you use right prefix of the subject like below when you post patch?
>>
>> 'drm/exynos: ...', not 'drm: Exynos: ...'
>>
>> Your email will be filtered from my mailbox if you don't use the right
>> prefix so I couldn't check and take care of your patch.
> 
> Ah, I didn't realise this. Maybe it could be good to not filter if the
> patch is also directly addressed/CCed to you, rather than a list?
> Gustavo Padovan is following this convention and I also will in future,
> but I guess it might lead to some patches being dropped from casual
> contributors if they don't know this.

Sorry for confusing. I don't really want to drop the patches which don't
use right prefix - undocumented. I have two filters, one is DRI mailing
list, other is drm/exynos. So if you use other prefix, your patch is
filtered and stored in my dri-devel mailbox. But as you may know, the
mailbox would always be full with many emails which contains various
type patches, exynos, omap, sti, radeon, intel and so no. So it wouldn't
be easy to pick up only your patch among them. So I'd like to recommend
you to use drm/exynos prefix so that I could review and pick it up
easily and quickly.

Thanks,
Inki Dae

> 
> Cheers,
> Daniel
> 
>>
>> Thanks,
>> Inki Dae
>>
>> On 2015년 03월 24일 17:57, Javier Martinez Canillas wrote:
>>>  Hello Inki,
>>>
>>>  On Tue, Mar 17, 2015 at 2:24 PM, Daniel Stone
>>> <daniels at collabora.com> wrote:
>>>>  When performing a modeset, use the framebuffer pitch value to set FIMD
>>>>  IMG_SIZE and Mixer SPAN registers. These are both defined as pitch
>>>> - the
>>>>  distance between contiguous lines (bytes for FIMD, pixels for mixer).
>>>>
>>>>  Fixes display on Snow (1366x768).
>>>>
>>>>  Signed-off-by: Daniel Stone <daniels at collabora.com>
>>>>  Tested-by: Javier Martinez Canillas <javier.martinez at collabora.co.uk>
>>>
>>>  Any comments on this patch? It would be great to pick this sooner
>>>  rather than later since it fixes (at least) display output on Snow and
>>>  HDMI output on Peach Pit/Pi.
>>>
>>>  Best regards,
>>>  Javier
>>>
>>
>>
> 



More information about the dri-devel mailing list