[PATCH 2/5] exynos: add EXYNOS_G2D_EVENT to drmHandleEvent
Tobias Jakobi
tjakobi at math.uni-bielefeld.de
Mon Mar 30 06:04:12 PDT 2015
Hello,
On 2015-03-30 02:02, Rob Clark wrote:
> so, iirc, vmwgfx also has some custom events.. not really sure if
> they have their own hand-rolled drmHandleEvent() or if they have
> another way of catching those.
>
> Maybe we need some more flexible way to register handlers for driver
> custom events? But everyone adding their own thing to
> drmHandleEvent() doesn't really seem so nice.. that said, I'm not
> sure how much to care. If it is just exynos and vmwgfx, then telling
> them to use there own version of of drmHandleEvent() might be ok. But
> if driver custom events somehow become more popular, maybe we want a
> better solution..
would something like this work for you guys:
https://www.math.uni-bielefeld.de/~tjakobi/archive/0001-custom-events.patch
(this is not compile tested or anything, just a draft)
Basically this introduces drmHandleEvent2, which is drmHandleEvent with
two additional arguments. The first one being a function pointer through
which the 'remaining' events (which are not handled by the common code)
are handled, and some (opaque) pointer to data that the handler might
need.
In the vendor specific code I then introcuded exynos_handle_event which
calls dramHandleEvent2 with a properly setup handler. vmwgfx could do
the same here I guess.
With best wishes,
Tobias
More information about the dri-devel
mailing list