[PATCH v3] libgencec: Add userspace library for the generic CEC kernel interface

[Emil Velikov]

Hi Kamil,

There are a couple of bits that I've missed out previously. All but
the missing install of libgencec.pc are general cleanups.

On 6 May 2015 at 13:37, Kamil Debski <k.debski at samsung.com> wrote:

> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,26 @@

> +/ar-lib
You can drop this (see the configure.ac note).

> +/aclocal.m4
> +/autom4te.cache/*
> +/config.*
> +/configure
> +/depcomp
> +/install-sh
> +/missing
Normally one can drop the leading forward slash in .gitignore files.
This way git won't bother if you build in a subdirectory - for example
$(project_top)/build.

> +/examples/.deps/*
> +/examples/.libs/*
> +src/.deps/*
> +src/.libs/*
One can replace these four with
.deps/
.libs/

> +/examples/cectest
echo cectest > examples/.gitignore


> --- /dev/null
> +++ b/Makefile.am
> @@ -0,0 +1,4 @@
> +SUBDIRS = src examples
> +ACLOCAL_AMFLAGS = -I m4
> +library_includedir=$(includedir)
> +library_include_HEADERS = include/gencec.h
We want to install the pc file. Otherwise one cannot really use it.

pkgconfigdir = $(libdir)/pkgconfig
pkgconfig_DATA = libgencec.pc


> --- /dev/null
> +++ b/configure.ac
> @@ -0,0 +1,27 @@
> +AC_PREREQ(2.60)
> +
> +AC_INIT([libgencec], [0.1], [k.debski at samsung.com])
> +AM_INIT_AUTOMAKE([-Wall -Werror foreign])
> +
> +AC_PROG_CC
> +AM_PROG_AR
There is not plan to use the library on Windows is there ? If so we
can remove this as per the manual [1].

"You must use this macro when you use the archiver in your project, if
you want support for unusual archivers such as Microsoft lib"

Cheers,
Emil

[1] http://www.gnu.org/software/automake/manual/html_node/Public-Macros.html