drm/exynos: Add atomic modesetting support

[Inki Dae]

Hi,

2015-05-09 6:51 GMT+09:00 Tobias Jakobi <liquid.acid at gmx.net>:
> Hello,
>
> I've tested this on my Hardkernel Odroid-X2 (connected via HDMI to a
> 1080p panel).
>
> Run the usual modetest tests (just primary plane, primary plane with
> vsync, primary plane with overlay, primary plane with overlay and video
> overlay, overlay partially outside of crtc area, etc.) and haven't
> noticed any issues so far.

As I mentioned several times, it works well in case that only one crtc
driver is enabled. Could you check it again after you enable two or
more crtc drivers such as FIMD and HDMI or FIMD, HDMI and VIDI
together? For this, dts file for X2 should contain their device nodes
and also should be configurated though menuconfig.

>
> Kernel log is 'clean', so the series works fine for me.
>
> You can add my
> Tested-by: Tobias Jakobi <tjakobi at math.uni-bielefeld.de>

So you didn't test it correctly yet.

Thanks,
Inki Dae

>
> With best wishes,
> Tobias
>
>
> Gustavo Padovan wrote:
>> Hi,
>>
>> Here goes the full support for atomic modesetting on exynos. I've
>> split the patches in the various phases of atomic support.
>>
>> v2: fixes comments by Joonyoung
>>         - remove unused var in patch 09
>>         - use ->disable instead of outdated ->dpms in hdmi code
>>         - remove WARN_ON from crtc enable/disable
>>
>> v3: fixes comment by Joonyoung
>>         - move the removal of drm_helper_disable_unused_functions() to
>>         separated patch
>>
>> v4: add patches that remove unnecessary calls to disable_plane()
>>
>>       Gustavo
>>
>> ---
>> Gustavo Padovan (12):
>>       drm/exynos: atomic phase 1: use drm_plane_helper_update()
>>       drm/exynos: atomic phase 1: use drm_plane_helper_disable()
>>       drm/exynos: atomic phase 1: add .mode_set_nofb() callback
>>       drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy()
>>       drm/exynos: atomic phase 2: keep track of framebuffer pointer
>>       drm/exynos: atomic phase 3: atomic updates of planes
>>       drm/exynos: atomic phase 3: use atomic .set_config helper
>>       drm/exynos: atomic phase 3: convert page flips
>>       drm/exynos: remove exported functions from exynos_drm_plane
>>       drm/exynos: don't disable unused functions at init
>>       drm/exynos: atomic dpms support
>>       drm/exynos: remove unnecessary calls to disable_plane()
>>
>>  drivers/gpu/drm/bridge/ps8622.c             |   6 +-
>>  drivers/gpu/drm/bridge/ptn3460.c            |   6 +-
>>  drivers/gpu/drm/exynos/exynos_dp_core.c     |   6 +-
>>  drivers/gpu/drm/exynos/exynos_drm_crtc.c    | 215 +++++++++----------------------
>>  drivers/gpu/drm/exynos/exynos_drm_dpi.c     |   6 +-
>>  drivers/gpu/drm/exynos/exynos_drm_drv.c     |   2 +
>>  drivers/gpu/drm/exynos/exynos_drm_drv.h     |   4 +-
>>  drivers/gpu/drm/exynos/exynos_drm_dsi.c     |   6 +-
>>  drivers/gpu/drm/exynos/exynos_drm_encoder.c |  35 +----
>>  drivers/gpu/drm/exynos/exynos_drm_fb.c      |  12 +-
>>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c   |   3 -
>>  drivers/gpu/drm/exynos/exynos_drm_plane.c   | 115 +++++++++--------
>>  drivers/gpu/drm/exynos/exynos_drm_plane.h   |  11 --
>>  drivers/gpu/drm/exynos/exynos_drm_vidi.c    |   6 +-
>>  drivers/gpu/drm/exynos/exynos_hdmi.c        |  10 +-
>>  15 files changed, 178 insertions(+), 265 deletions(-)
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel