[PATCH 1/4] drm: Remove extraneous parameter from kerneldoc

Daniel Stone daniel at fooishbar.org
Mon May 11 15:49:57 PDT 2015


Hi,

On Monday, May 11, 2015, Daniel Vetter <daniel at ffwll.ch> wrote:

> On Sat, May 09, 2015 at 03:52:10PM +0100, Daniel Stone wrote:
> > 672cb1d6ae mistakenly added an extra parameter to the kerneldoc for
> > drm_property_unreference_blob which wasn't actually present.
> >
> > Signed-off-by: Daniel Stone <daniels at collabora.com <javascript:;>>
> > ---
> >  drivers/gpu/drm/drm_crtc.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 4f922aa..6f3cafb 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -4267,7 +4267,6 @@ static void drm_property_free_blob(struct kref
> *kref)
> >   *
> >   * Drop a reference on a blob property. May free the object.
> >   *
> > - * @param dev  Device the blob was created on
>
> Same issue with drm_property_unreference_blob_locked. Also this isn't
> kerneldoc syntax, the proper one is
>
>  * @blob: Pointer to blob property
>
> $ make htmldocs complains about a bunch of your recently added kerneldoc
> still. I've squashed this one in, but can you pls follow up with more
> fixups (and respin the later patches in this series too)?
>

Augh, had left my editor in Doxygen mode, and hadn't noticed thanks to the
802.11 doc breakage masking everything else.

New branch is up at git://git.collabora.co.uk/git/user/daniels/linux
wip/4.1.x/drm-blob-props - will send it out to the list when I get in
tomorrow morning. Got sidetracked fixing up more unify-flip-modeset issues
instead :\

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150511/09a077e3/attachment-0001.html>


More information about the dri-devel mailing list