[PATCH] fix typo for drmOpenByName

Daniel Kurtz djkurtz at chromium.org
Thu May 14 03:53:17 PDT 2015


NAK.  The original code is correct.

On Thu, May 14, 2015 at 2:17 PM, Guo Yejun <yejun.guo at intel.com> wrote:
> Signed-off-by: Guo Yejun <yejun.guo at intel.com>
> ---
>  xf86drm.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/xf86drm.c b/xf86drm.c
> index f7c45f8..5e7306e 100644
> --- a/xf86drm.c
> +++ b/xf86drm.c
> @@ -635,9 +635,8 @@ static int drmOpenByName(const char *name, int type)
>                     drmFreeVersion(version);
>                     id = drmGetBusid(fd);
>                     drmMsg("drmGetBusid returned '%s'\n", id ? id : "NULL");
> -                   if (!id || !*id) {
> -                       if (id)
> -                           drmFreeBusid(id);

This code basically says:
If no string was returned (id == NULL), or an empty string (*id ==
NULL), aka "", then return fd and free id if it was an empty string.

> +                   if (id && *id) {
> +                       drmFreeBusid(id);
>                         return fd;
>                     } else {
>                         drmFreeBusid(id);
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list