[PATCH] drm/bridge: use flags argument of devm_gpiod_get to set direction

Thierry Reding treding at nvidia.com
Tue May 19 01:06:54 PDT 2015


On Tue, May 19, 2015 at 09:03:49AM +0200, Uwe Kleine-K├Ânig wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
> 
> Use this to simplify the driver. Furthermore this is one caller less
> that stops us making the flags argument to gpiod_get*() mandatory.
> 
> Fixes: b2ea8772799d ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")

There's no need for this. The patch refactors code, but it doesn't fix
anything. Including a "Fixes:" line will cause people to pick this up
for stable releases, which I don't think is warranted in this case.

I've applied the patch with the "Fixes:" line removed.

Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150519/5d4f030c/attachment.sig>


More information about the dri-devel mailing list