[PATCH 3/4] drm/tegra: Add VIC support
Mikko Perttunen
mikko.perttunen at kapsi.fi
Thu May 21 08:44:08 PDT 2015
On 05/21/2015 06:10 PM, Arto Merilainen wrote:
> ...
>>> +
>>> + vic->rst = devm_reset_control_get(dev, "vic03");
>>
>> I might prefer just "vic" as the clock/reset name. The name is often
>> used as a sort of "role" for the clock/reset for the device, not
>> necessarily the raw name of the "correct" clock/reset.
>>
>
> I considered that - but I then noticed that
> drivers/clk/tegra/clk-tegra124.c was already using vic03 variant. I can
> write a patch for changing that too.
Well, the two can be different; the clock-name in device tree kind of
means "string that i use to refer to a clock that powers the VIC unit".
It's not really a big deal though, both ways are used in DT bindings.
Mikko
More information about the dri-devel
mailing list