[PATCH] drm: Remove misleading paragraph from drm_vblank_pre_modeset kerneldoc comment

Michel Dänzer michel at daenzer.net
Tue May 26 02:14:50 PDT 2015


From: Michel Dänzer <michel.daenzer at amd.com>

drm_vblank_pre/post_modeset work fine for the radeon driver even though
it uses hardware counters, including suspend/resume.

Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
---
 drivers/gpu/drm/drm_irq.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index f9634da..0dcd73d 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -1346,13 +1346,6 @@ EXPORT_SYMBOL(drm_crtc_vblank_on);
  * software-side vblank frame counting will ensure that there are no jumps or
  * discontinuities.
  *
- * Unfortunately this approach is racy and also doesn't work when the vblank
- * interrupt stops running, e.g. across system suspend resume. It is therefore
- * highly recommended that drivers use the newer drm_vblank_off() and
- * drm_vblank_on() instead. drm_vblank_pre_modeset() only works correctly when
- * using "cooked" software vblank frame counters and not relying on any hardware
- * counters.
- *
  * Drivers must call drm_vblank_post_modeset() when re-enabling the same crtc
  * again.
  */
-- 
2.1.4



More information about the dri-devel mailing list