[PATCH] drm/sti: load HQVDP firmware the first time HQVDP's plane is used

Emil Velikov emil.l.velikov at gmail.com
Tue Nov 3 06:55:54 PST 2015


Hi Vincent,

On 2 November 2015 at 10:05, Vincent Abriou <vincent.abriou at st.com> wrote:
> @@ -754,6 +901,9 @@ static void sti_hqvdp_atomic_update(struct drm_plane *drm_plane,
>         sti_hqvdp_update_hvsrc(HVSRC_VERT, scale_v, &cmd->hvsrc);
>
>         if (first_prepare) {
> +               /* Start HQVDP XP70 coprocessor */
> +               sti_hqvdp_start_xp70(hqvdp);
> +
Shouldn't one check for things such as this (and
sti_hqvdp_check_hw_scaling, amongst other things) in atomic_check() ?
Mostl/all other drivers seems to do so. After all drm core check()s
and if everything/state is ok then calls update().

Regards,
Emil


More information about the dri-devel mailing list