[PATCH 0/9] uapi: drm: fixes for userspace compilation

Gabriel Laskar gabriel at lse.epita.fr
Fri Nov 13 13:36:31 PST 2015


On Fri, 13 Nov 2015 20:38:51 +0000
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 13 November 2015 at 19:31, Gabriel Laskar <gabriel at lse.epita.fr> wrote:
> > On Fri, 13 Nov 2015 20:24:30 +0100
> > Gabriel Laskar <gabriel at lse.epita.fr> wrote:
> >  
> > Sorry for the noise, I had just saw the first version.
> >  
> Heh I was wondering what's happening. I guess I should have been more
> helpful and given you a link, rather than just throwing you a name.
> Sorry about that.

No worries, I will check a little more next time.

> From a very quick look I believe that the only part that is not
> covered by Mikko is virtgpu_drm.h as it landed recently. Other than
> that - with the explicit include of drm.h from the respective headers,
> and the stdint to __foo type conversion things should actually work.

I will resend that patch.

There is still some issues on the headers, like the inclusion of drm.h.

AFAIK, we should include "drm.h", in order to minimize the changes
between linux/libdrm when importing, as the folders are not always the
same (on Archlinux for example, drm.h is installed
in /usr/include/libdrm/drm.h). This is not always the case in some of
the headers:

* drm_sarea.h
* exynos_drm.h
* i810_drm.h
* i915_drm.h
* mga_drm.h
* msm_drm.h
* nouveau_drm.h
* omap_drm.h
* r128_drm.h
* savage_drm.h
* tegra_drm.h
* via_drm.h
* vmwgfx_drm.h (with #ifndef __KERNEL__ guards around it)

* there is still some headers that are including stddef.h for no
  visible reasons (msm_drm.h and qxl_drm.h).
* drm_fourcc.h and drm_mode.h are still using linux/types.h

I can send patches for them too, I just need to know if this is useful,
and not just nitpicking for you.

-- 
Gabriel Laskar


More information about the dri-devel mailing list