[PATCH 0/9] uapi: drm: fixes for userspace compilation

[Michel Dänzer]

On 14.11.2015 07:06, Emil Velikov wrote:
> On 13 November 2015 at 21:36, Gabriel Laskar <gabriel at lse.epita.fr> wrote:
>>
>> There is still some issues on the headers, like the inclusion of drm.h.
>>
>> AFAIK, we should include "drm.h", in order to minimize the changes
>> between linux/libdrm when importing, as the folders are not always the
>> same (on Archlinux for example, drm.h is installed
>> in /usr/include/libdrm/drm.h). This is not always the case in some of
>> the headers:
>>
> I'm afraid we cannot do this. Things should just work without the
> extra include directive (from your earlier example). We can easily fix
> this and other issues in an automated way during import.

[...]

>> I can send patches for them too, I just need to know if this is useful,
>> and not just nitpicking for you.
>>
> Everything but the s|drm/drm.h|drm.h| suggestion is pretty valid imho.

What's the problem with changing

#include <drm/drm.h>

to

#include "drm.h"

in include/uapi/drm/*_drm.h? I recently made that change in radeon_drm.h
and amdgpu_drm.h for the reason Gabriel mentioned above (in particular
amdgpu_drm.h is now basically identical between the kernel and libdrm
trees), and I haven't noticed any problems because of that.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer