[PATCH] drm: Do not set connector->encoder in drivers

Daniel Vetter daniel at ffwll.ch
Tue Nov 17 08:16:53 PST 2015


On Tue, Nov 17, 2015 at 04:58:25PM +0200, Jani Nikula wrote:
> On Mon, 16 Nov 2015, Thierry Reding <thierry.reding at gmail.com> wrote:
> > An encoder is associated with a connector by the DRM core as a result of
> > setting up a configuration. Drivers using the atomic or legacy helpers
> > should never set up this link, even if it is a static one.
> 
> Not to block this patch in any way, but really this kind of stuff should
> end up in the struct drm_connector kernel-doc. Although it's already a
> monster.

In 4.4 we can split up the kerneldoc for structures into per-member
comments, which was added exactly to handle monsters like this. Also, with
the per-member comment layout you can do full paragraphs to explain tricky
bits like this separately and are no longer limited to the single
(continuated if needed) line we have right now.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list