[patch] drm/vmwgfx: fix a warning message

Sinclair Yeh syeh at vmware.com
Tue Nov 24 11:55:49 PST 2015


Thanks!

Reviewed-by: Sinclair Yeh <syeh at vmware.com>

On Sat, Nov 21, 2015 at 01:29:39PM +0300, Dan Carpenter wrote:
> The WARN_ON() macro only takes a condition argument, it doesn't take
> a message.  I have converted this to WARN() instead.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> index a8baf5f..b6a0806 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
>  	else if (ctx_id == SVGA3D_INVALID_ID)
>  		ret = vmw_local_fifo_reserve(dev_priv, bytes);
>  	else {
> -		WARN_ON("Command buffer has not been allocated.\n");
> +		WARN(1, "Command buffer has not been allocated.\n");
>  		ret = NULL;
>  	}
>  	if (IS_ERR_OR_NULL(ret)) {


More information about the dri-devel mailing list