[PATCH] drm: Correct arguments to list_tail_add in create blob ioctl

Sean Paul seanpaul at chromium.org
Thu Oct 8 07:10:24 PDT 2015


From: Maneet Singh <mmaneetsingh at nvidia.com>

From: Maneet Singh <mmaneetsingh at nvidia.com>

Arguments passed to list_add_tail were reversed resulting in deletion
of old blob property everytime the new one is added.

Signed-off-by: Maneet Singh <mmaneetsingh at nvidia.com>
[seanpaul tweaked commit subject a little]
Signed-off-by: Sean Paul <seanpaul at chromium.org>
Reviewed-by: Daniel Stone <daniels at collabora.com>
---
 drivers/gpu/drm/drm_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index e600a5f..049c7b7 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -4454,7 +4454,7 @@ int drm_mode_createblob_ioctl(struct drm_device *dev,
 	 * not associated with any file_priv. */
 	mutex_lock(&dev->mode_config.blob_lock);
 	out_resp->blob_id = blob->base.id;
-	list_add_tail(&file_priv->blobs, &blob->head_file);
+	list_add_tail(&blob->head_file, &file_priv->blobs);
 	mutex_unlock(&dev->mode_config.blob_lock);
 
 	return 0;
-- 
2.6.0.rc2.230.g3dd15c0



More information about the dri-devel mailing list