[PATCH 03/20] drm/atmel-hlcdc: Constify function pointer structs
Boris Brezillon
boris.brezillon at free-electrons.com
Fri Oct 9 13:59:29 PDT 2015
Hi Ville,
On Wed, 2 Sep 2015 13:44:01 +0300
ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Moves a bunch of junk to .rodata from .data.
>
> drivers/gpu/drm/atmel-hlcdc/atmel-hlcdc-dc.ko:
> -.text 12488
> +.text 12480
> -.rodata 1696
> +.rodata 1760
> -.data 776
> +.data 712
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
Again, just for the record since Thierry already have this patch in his
DRM trivial tree:
Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> index 067e4c1..250f69e 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> @@ -146,7 +146,7 @@ atmel_hlcdc_rgb_encoder_mode_set(struct drm_encoder *encoder,
> cfg);
> }
>
> -static struct drm_encoder_helper_funcs atmel_hlcdc_panel_encoder_helper_funcs = {
> +static const struct drm_encoder_helper_funcs atmel_hlcdc_panel_encoder_helper_funcs = {
> .mode_fixup = atmel_hlcdc_panel_encoder_mode_fixup,
> .mode_set = atmel_hlcdc_rgb_encoder_mode_set,
> .disable = atmel_hlcdc_panel_encoder_disable,
> @@ -192,7 +192,7 @@ atmel_hlcdc_rgb_best_encoder(struct drm_connector *connector)
> return &rgb->encoder;
> }
>
> -static struct drm_connector_helper_funcs atmel_hlcdc_panel_connector_helper_funcs = {
> +static const struct drm_connector_helper_funcs atmel_hlcdc_panel_connector_helper_funcs = {
> .get_modes = atmel_hlcdc_panel_get_modes,
> .mode_valid = atmel_hlcdc_rgb_mode_valid,
> .best_encoder = atmel_hlcdc_rgb_best_encoder,
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the dri-devel
mailing list