[PATCH v2 1/3] drm: dw_hdmi: use of_get_i2c_adapter_by_node interface
Vladimir Zapolskiy
vladimir_zapolskiy at mentor.com
Mon Oct 12 06:14:01 PDT 2015
David, Russel,
ping.
On 23.09.2015 00:48, Vladimir Zapolskiy wrote:
> This change is needed to properly lock I2C bus driver, which serves DDC.
>
> The change fixes an overflow over zero of I2C bus driver user counter:
>
> root at mx6q:~# lsmod | grep i2c
> i2c_imx 15348 0
> root at mx6q:~# lsmod | grep dw_hdmi_imx
> dw_hdmi_imx 3567 0
> dw_hdmi 15850 1 dw_hdmi_imx
> imxdrm 8610 3 dw_hdmi_imx,imx_ipuv3_crtc,imx_ldb
> root at mx6q:~# rmmod dw_hdmi_imx
> root at mx6q:~# lsmod | grep i2c
> i2c_imx 15348 -1
>
> ^^^^^
>
> root at mx6q:~# rmmod i2c_imx
> rmmod: ERROR: Module i2c_imx is in use
>
> Note that prior to this change put_device() coupled with
> of_find_i2c_adapter_by_node() was missing on error path of
> dw_hdmi_bind(), added i2c_put_adapter() there along with the change.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy at mentor.com>
> Cc: Russell King <rmk+kernel at arm.linux.org.uk>
> Cc: Philipp Zabel <p.zabel at pengutronix.de>
> Cc: Andy Yan <andy.yan at rock-chips.com>
--
With best wishes,
Vladimir
More information about the dri-devel
mailing list