[PATCH libdrm 2/2] xf86drmMode: smoke-test the atomic API

[Emil Velikov]

On 07/09/15 14:06, Ville Syrjälä wrote:
> On Mon, Sep 07, 2015 at 10:53:06AM +0100, Emil Velikov wrote:
>> As going through the modetest patches for atomic support I've noticed
>> that if we pass NULL for the drmModeAtomicReqPtr argument we'll crash.
>>
>> So let's handle things appropriately if the user forgot to check the
>> return value of drmModeAtomicAlloc and drmModeAtomicDuplicate or made a
>> typo somewhere along the way.
> 
> I'm not sure hand-holding the user to such an extent is actually useful.
>From what I've gathered "smoke-testing" is not meant to be smart.

> OTOH I guess one NULL check per function call isn't all that expensive
> either.
> 
This is pretty much the reason why I bothered :)

Although if anyone feels strongly against it I'll drop the patch.

Thanks
Emil