[PATCH RFCv2 3/4] staging: etnaviv: add drm driver

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Sep 16 01:04:35 PDT 2015


On Fri, Sep 11, 2015 at 04:10:13PM +0200, Lucas Stach wrote:
> From: Christian Gmeiner <christian.gmeiner at gmail.com>
> 
> This is a squashed commit of the complete etnaviv DRM driver in order
> to make it easy for people to review the code by seeing the driver as a
> whole and is not intended for merging in this form.
> 
> If you are interested in the history of individual commits:
> git://git.pengutronix.de/git/lst/linux.git etnaviv-for-upstream
> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

Lucas,

I know that the previous round, people said that they didn't like the
individual patches posted, but squashing everything together into one
patch is also not good.

It would make more sense (at least for me) if you squashed the work
that has already been done into one patch, and then post your updates
as individual patches.  That way, Christian and myself can see what
the changes are against some known without having to dig through your
git tree, and those who complained about all the patches last time
have fewer patches to look at.

Expecting those in the project to page through thousands of lines that
they already know about, hoping to spot the changes you've made is
really very unreasonable and error prone.  I will _NOT_ be wasting my
time reviewing this mega-patch exactly because of that.

I _might_, if I get time, pull a copy of your git tree to look at the
individual patches, but I'm not going to reply quoting bits of this
patch - I may reply with comments but without any context.

Sorry.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.


More information about the dri-devel mailing list