[PATCH RFCv2 3/4] staging: etnaviv: add drm driver

[Eric Anholt]

Russell King - ARM Linux <linux at arm.linux.org.uk> writes:

> On Wed, Sep 16, 2015 at 11:05:11AM -0400, Eric Anholt wrote:
>> Lucas Stach <l.stach at pengutronix.de> writes:
>> 
>> > From: Christian Gmeiner <christian.gmeiner at gmail.com>
>> 
>> > +static bool etnaviv_validate_load_state(struct etnaviv_gpu *gpu, u32 *buf,
>> > +	unsigned int state, unsigned int num)
>> > +{
>> > +	return true;
> ...
>> > +}
>> 
>> I was browsing the code, and noticed that it looks like you've got a
>> debugging early return in your validation function here.
>
> That's because it's not quite ready to be enabled yet - the code as
> it stands in my tree doesn't have the infrastructure to validate that
> a LOADSTATE which touches an address register (or similar) has a
> relocation appropriately marked, due to the way things happen.
> Hopefully, when the user/kernel API is sorted, this can be resolved.

OK.  Validation code is painful to write, so I was just browsing what
was in here to see if I could pick up anything useful.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150916/ee6b5b12/attachment.sig>