[PATCH] drm/vmwgfx: fix return of garbage
Sudip Mukherjee
sudipm.mukherjee at gmail.com
Thu Sep 17 01:19:53 PDT 2015
Incase of error we printed the error message and returned ret. But ret
was never initialized and so we have been returning garbage value on
error.
Signed-off-by: Sudip Mukherjee <sudip at vectorindia.org>
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 61fb7f3..43ed33f1 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
struct drm_crtc *crtc;
u32 num_units = 0;
u32 i, k;
- int ret;
dirty->dev_priv = dev_priv;
@@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
if (!dirty->cmd) {
DRM_ERROR("Couldn't reserve fifo space "
"for dirty blits.\n");
- return ret;
+ return -EIO;
}
memset(dirty->cmd, 0, dirty->fifo_reserve_size);
}
--
1.9.1
More information about the dri-devel
mailing list