[PATCH 09/16] drm/irq: Use unsigned int pipe in public API

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Sep 24 12:21:53 PDT 2015


On Thu, Sep 24, 2015 at 06:35:31PM +0200, Thierry Reding wrote:
> This continues the pattern started in commit cc1ef118fc09 ("drm/irq:
> Make pipe unsigned and name consistent"). This is applied to the public
> APIs and driver callbacks, so pretty much all drivers need to be updated
> to match the new prototypes.

I don't like being forced to use the "pipe" naming in all drivers; I
found that really confusing when I first looked at DRM, and it took
a long time to work out that "pipe" basically means "crtc" or "gpu".

What's wrong with keeping "crtc" as the index terminology for crtc
things?  Surely that's more descriptive of what's going on here?

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.


More information about the dri-devel mailing list