[PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed

Charles Keepax ckeepax at opensource.wolfsonmicro.com
Wed Sep 30 06:15:22 PDT 2015


On Wed, Sep 30, 2015 at 08:26:37PM +0900, Inki Dae wrote:
> Hi,
> 
> On 2015년 09월 28일 01:11, Charles Keepax wrote:
> > If binding failed calling exynos_dp_enable in exynos_dp_resume will
> > result in several NULL pointer dereferences. It is much better to
> > simply skip suspend/resume handling if bind has failed, do so by
> > checking if a drm_dev exists.
> 
> Thanks for your patch. However, the pm interfaces of KMS drivers aren't
> required because these are controlled by top of Exynos drm driver and
> connector dpms. So I posted a patch that it removes pm interfaces of dp
> driver.

No problems at all, as long as my Arndale starts resuming without
a NULL pointer I am happy :-)

Had a quick test of your patch it appears to fix my issue as well
so totally fine with that.

Thanks,
Charles


More information about the dri-devel mailing list