[PATCH] drm/edid: Fix EDID Established Timings I and II

[Ville Syrjälä]

On Sat, Apr 02, 2016 at 11:08:06AM +0100, Paul Parsons wrote:
> Three of the VESA DMT timings in edid_est_modes[] are slightly off.
> 1. 640x480 at 72Hz vsync_end should be 492, not 491.
> 2. 640x480 at 60Hz clock should be 25175, not 25200.
> 3. 1024x768 at 75Hz clock should be 78750, not 78800.
> This patch corrects those timings per the VESA DMT specification, and
> thus brings them into line with the identical timings in drm_dmt_modes[].
> 
> Signed-off-by: Paul Parsons <lost.distance at yahoo.com>

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

I also noticed a discrepancy with the 1024x768i 87Hz 8514/A mode. The
front porch for this particular mode should be 4 lines per field, so
8 lines for the frame. The EST timing looks correct, but the DMT one
is wrong (only accounts for one field). Care to send a patch to fix
that one as well?

> ---
> 
> diff -ru a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> --- a/drivers/gpu/drm/drm_edid.c	2016-03-14 04:28:54.000000000 +0000
> +++ b/drivers/gpu/drm/drm_edid.c	2016-04-02 10:29:30.178958556 +0100
> @@ -521,12 +521,12 @@
>  		   720, 840, 0, 480, 481, 484, 500, 0,
>  		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) }, /* 640x480 at 75Hz */
>  	{ DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 31500, 640, 664,
> -		   704,  832, 0, 480, 489, 491, 520, 0,
> +		   704,  832, 0, 480, 489, 492, 520, 0,
>  		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) }, /* 640x480 at 72Hz */
>  	{ DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 30240, 640, 704,
>  		   768,  864, 0, 480, 483, 486, 525, 0,
>  		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) }, /* 640x480 at 67Hz */
> -	{ DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 25200, 640, 656,
> +	{ DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 25175, 640, 656,
>  		   752, 800, 0, 480, 490, 492, 525, 0,
>  		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) }, /* 640x480 at 60Hz */
>  	{ DRM_MODE("720x400", DRM_MODE_TYPE_DRIVER, 35500, 720, 738,
> @@ -538,7 +538,7 @@
>  	{ DRM_MODE("1280x1024", DRM_MODE_TYPE_DRIVER, 135000, 1280, 1296,
>  		   1440, 1688, 0, 1024, 1025, 1028, 1066, 0,
>  		   DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1280x1024 at 75Hz */
> -	{ DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 78800, 1024, 1040,
> +	{ DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 78750, 1024, 1040,
>  		   1136, 1312, 0,  768, 769, 772, 800, 0,
>  		   DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1024x768 at 75Hz */
>  	{ DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 75000, 1024, 1048,
> 
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC