[PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings
kbuild test robot
fengguang.wu at intel.com
Wed Apr 13 07:07:42 UTC 2016
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Karol Herbst <nouveau at karolherbst.de>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---
base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
@@ -129,8 +129,7 @@ nvkm_iccsense_dtor(struct nvkm_subdev *s
{
struct nvkm_iccsense *iccsense = nvkm_iccsense(subdev);
- if (iccsense->rails)
- kfree(iccsense->rails);
+ kfree(iccsense->rails);
return iccsense;
}
More information about the dri-devel
mailing list