[PATCH 1/4] drm/omap: Fix missing includes

[Tomi Valkeinen]

On 19/04/16 11:32, Laurent Pinchart wrote:

>>> This driver uses the gpiod API only, you can remove gpio.h and of_gpio.h.
>>
>> True. I don't want to mix fixes and cleanups, so I made a new patch for
>> that:
> 
> Given that you touch the two files in your "Fix missing includes" patch that 
> seems a bit overkill to me, I would have squashed the two together, but it 
> doesn't matter too much.

If the only thing the "Fix missing includes" patch would do is to touch
those two files and add the gpio/consumer.h, then... maybe. But it's
touching other files, and adding of.h too.

Maybe I'm being too pedantic, but I don't want to mix separate things
into the same patch. If in the description I write "This patch also does
xyz", I know I should split it up =).

I could have squashed the patch and just talked about "cleaning up the
includes". But that's not true, as the first patch is fixing compilation
issues.

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160419/435e317b/attachment.sig>