[PATCH] drm: Fix compilation on systems that don't provide O_CLOEXEC

Stefan Dirsch sndirsch at suse.de
Thu Apr 21 13:51:17 UTC 2016


On Thu, Apr 21, 2016 at 01:37:22PM +0100, Emil Velikov wrote:
> On 20 April 2016 at 16:25, Stefan Dirsch <sndirsch at suse.de> wrote:
> > On Wed, Apr 20, 2016 at 04:47:20PM +0200, Daniel Vetter wrote:
> >> On Wed, Apr 20, 2016 at 4:39 PM, Stefan Dirsch <sndirsch at suse.de> wrote:
> >> > Patch suggestion by Thomas Klausner. See also
> >> > http://mail-index.netbsd.org/pkgsrc-changes/2012/08/13/msg076887.html
> >> >
> >> > Signed-off-by: Stefan Dirsch <sndirsch at suse.de>
> >>
> >> Fix your OS to have O_CLOEXEC semantics I think is what should happen
> >> here. It's an obvious race in multi-threaded apps, and you need a fix
> >> for it anyway.
> >> -Daniel
> >
> > Indeed I figured out the patch is no longer needed and finally removed it. ;-)
> >
> No problem Stefan and thanks for starting to get the Suse patches upstreamed.

You're welcome. I'm trying my best. ;-)

> A few friendly suggestions - please correctly the patch author (if not
> yourself) and don't add their s-o-b unless they have done/agreed so.

Fixed and resent. ;-)

Thanks,
Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
---------------------------------------------------------------
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---------------------------------------------------------------


More information about the dri-devel mailing list