[PATCH] On hurd other includes are required to compile.

Emil Velikov emil.l.velikov at gmail.com
Sun Apr 24 20:20:09 UTC 2016


Hi Tobias,

On 24 April 2016 at 09:09, Tobias Frost <tobi at coldtobi.de> wrote:
> As both BSD and Hurd needs also the typedefs, so making sure that they are
> become declared when not compiling for linux.
> ---
>  include/drm/drm.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm.h b/include/drm/drm.h
> index b4ebaa9..e77146f 100644
> --- a/include/drm/drm.h
> +++ b/include/drm/drm.h
> @@ -42,10 +42,14 @@
>  #include <asm/ioctl.h>
>  typedef unsigned int drm_handle_t;
>
> +#elif defined(__GNU__) /* this is hurd */
> +#include <stdint.h>
> +#include <mach/i386/ioccom.h>
>  #else /* One of the BSDs */
> -
>  #include <sys/ioccom.h>
>  #include <sys/types.h>
> +#endif
> +#if !defined(__linux__)

The patch should be based against the linux kernel. Namely

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/drm/drm.h

I would kindly ask that you familiarise yourself with the
SubmittingPatches document [1] if you haven't already
But before anything, can we hear please on the "using i386 in the
include feels hacky" topic mentioned in the other patch.

Thanks
Emil

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches


More information about the dri-devel mailing list