[PATCH] rcar-du: add/rename DEFR6 TCON bits

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Mon Apr 25 11:34:23 UTC 2016


On 4/25/2016 10:25 AM, Geert Uytterhoeven wrote:

>> The  TCNE2 bit  of the DEFR6 register was renamed to TCNE1 in the R-Car gen2
>> manuals -- which makes more  sense as that bit controls whether DU1, not DU2
>> is connected to TCON.
>>
>> While at it, add the TCNE0 bit which controls whether DU0 is connected to
>> TCON.
>>
>> Based on the large patch by Andrey Gusakov <andrey.gusakov at cogentembedded.com>.
>>
>> Signed-off-by: Andrey Gusakov <andrey.gusakov at cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>
> I hard a hard time finding this register, as it's actually called "DEF6R"...

    Well, the R-Car M1A manual named it this way, hence is this name in the 
driver, I guess.

> Care to update /DEFRx/DEFxR/ as well?

    No. :-)

> Regardless:
> Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>

    Thank you.

[...]

MBR, Sergei



More information about the dri-devel mailing list