[PATCH 06/23] drm: omapdrm: fb: Turn framebuffer creation error messages into debug
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue Apr 26 20:35:28 UTC 2016
Don't print userspace parameters validation failures as error messages
to avoid giving userspace the ability to flood the kernel log.
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
drivers/gpu/drm/omapdrm/omap_fb.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c
index 8629ba6ff9d7..2edf86ab1fe1 100644
--- a/drivers/gpu/drm/omapdrm/omap_fb.c
+++ b/drivers/gpu/drm/omapdrm/omap_fb.c
@@ -422,8 +422,8 @@ struct drm_framebuffer *omap_framebuffer_init(struct drm_device *dev,
}
if (!format) {
- dev_err(dev->dev, "unsupported pixel format: %4.4s\n",
- (char *)&mode_cmd->pixel_format);
+ dev_dbg(dev->dev, "unsupported pixel format: %4.4s\n",
+ (char *)&mode_cmd->pixel_format);
ret = -EINVAL;
goto fail;
}
@@ -439,13 +439,13 @@ struct drm_framebuffer *omap_framebuffer_init(struct drm_device *dev,
mutex_init(&omap_fb->lock);
if (format->num_planes == 2 && pitch != mode_cmd->pitches[1]) {
- dev_err(dev->dev, "pitches differ between planes 0 and 1\n");
+ dev_dbg(dev->dev, "pitches differ between planes 0 and 1\n");
ret = -EINVAL;
goto fail;
}
if (pitch < mode_cmd->width * format->stride_bpp) {
- dev_err(dev->dev,
+ dev_dbg(dev->dev,
"provided buffer pitch is too small! %u < %u\n",
pitch, mode_cmd->width * format->stride_bpp);
ret = -EINVAL;
@@ -453,7 +453,7 @@ struct drm_framebuffer *omap_framebuffer_init(struct drm_device *dev,
}
if (pitch % format->stride_bpp != 0) {
- dev_err(dev->dev,
+ dev_dbg(dev->dev,
"buffer pitch (%u bytes) is not a multiple of pixel size (%u bytes)\n",
pitch, format->stride_bpp);
ret = -EINVAL;
@@ -467,7 +467,7 @@ struct drm_framebuffer *omap_framebuffer_init(struct drm_device *dev,
size = pitch * mode_cmd->height / format->sub_y[i];
if (size > (omap_gem_mmap_size(bos[i]) - mode_cmd->offsets[i])) {
- dev_err(dev->dev,
+ dev_dbg(dev->dev,
"provided buffer object is too small! %d < %d\n",
bos[i]->size - mode_cmd->offsets[i], size);
ret = -EINVAL;
--
2.7.3
More information about the dri-devel
mailing list