[PATCH 07/35] drm: Make drm_vm_open/close_locked private to drm_vm.c

Alex Deucher alexdeucher at gmail.com
Tue Apr 26 21:42:47 UTC 2016


On Tue, Apr 26, 2016 at 1:29 PM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> It's only used for legacy mmaping support now.
>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/drm_internal.h |  2 --
>  drivers/gpu/drm/drm_vm.c       | 16 ++++------------
>  2 files changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
> index c81ff4769e7b..902cf6a15212 100644
> --- a/drivers/gpu/drm/drm_internal.h
> +++ b/drivers/gpu/drm/drm_internal.h
> @@ -37,8 +37,6 @@ int drm_irq_by_busid(struct drm_device *dev, void *data,
>
>  /* drm_vm.c */
>  int drm_vma_info(struct seq_file *m, void *data);
> -void drm_vm_open_locked(struct drm_device *dev, struct vm_area_struct *vma);
> -void drm_vm_close_locked(struct drm_device *dev, struct vm_area_struct *vma);
>
>  /* drm_prime.c */
>  int drm_prime_handle_to_fd_ioctl(struct drm_device *dev, void *data,
> diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c
> index f90bd5fe35ba..ac9f4b3ec615 100644
> --- a/drivers/gpu/drm/drm_vm.c
> +++ b/drivers/gpu/drm/drm_vm.c
> @@ -395,16 +395,8 @@ static const struct vm_operations_struct drm_vm_sg_ops = {
>         .close = drm_vm_close,
>  };
>
> -/**
> - * \c open method for shared virtual memory.
> - *
> - * \param vma virtual memory area.
> - *
> - * Create a new drm_vma_entry structure as the \p vma private data entry and
> - * add it to drm_device::vmalist.
> - */
> -void drm_vm_open_locked(struct drm_device *dev,
> -               struct vm_area_struct *vma)
> +static void drm_vm_open_locked(struct drm_device *dev,
> +                              struct vm_area_struct *vma)
>  {
>         struct drm_vma_entry *vma_entry;
>
> @@ -429,8 +421,8 @@ static void drm_vm_open(struct vm_area_struct *vma)
>         mutex_unlock(&dev->struct_mutex);
>  }
>
> -void drm_vm_close_locked(struct drm_device *dev,
> -               struct vm_area_struct *vma)
> +static void drm_vm_close_locked(struct drm_device *dev,
> +                               struct vm_area_struct *vma)
>  {
>         struct drm_vma_entry *pt, *temp;
>
> --
> 2.8.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list