[PATCH] drm/etnaviv: remove BUG_ON in MMU unmap path

Lucas Stach l.stach at pengutronix.de
Wed Apr 27 12:38:18 UTC 2016


If the MMU map fails caused by an unaligned SG entry, the unmap path
is called to undo all already setup SG mappings. When encountering the
unaligned SG the unmap path hangs the kernel with a BUG(), while the
error is recoverable by just failing the submit that references the
faulty object.

Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
---
 drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
index 29a723fabc17..ebbb31ec9feb 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
@@ -83,8 +83,6 @@ int etnaviv_iommu_unmap(struct etnaviv_iommu *iommu, u32 iova,
 
 		VERB("unmap[%d]: %08x(%zx)", i, iova, bytes);
 
-		BUG_ON(!PAGE_ALIGNED(bytes));
-
 		da += bytes;
 	}
 
-- 
2.8.0.rc3



More information about the dri-devel mailing list