[PATCH 00/24] drm: add extern C guard for the UAPI headers

Dave Airlie airlied at gmail.com
Wed Apr 27 21:57:07 UTC 2016


On 28 April 2016 at 07:45, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 27 April 2016 at 10:47, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
>> On Thu, Apr 21, 2016 at 09:17:13PM +0100, Emil Velikov wrote:
>>> Dave Airlie pointed out that "polluting" the headers in a manner as seen
>>> with this series might not be too wise. David H, can we hear your view
>>> on the topic ?
>>
>> For armada and etnaviv, it seems sensible, so I'd be happy to see the
>> change go in if it means less work for others.
>>
>> Hence, for patch 2 and 4,
>>
>> Acked-by: Russell King <rmk+kernel at arm.linux.org.uk>
>>
> Thank you Russel !
>
>
> Dave, David H,
>
> So far we've got 6 (if we count the one Rob gave over IRC) acks on the topic.
>
> How do we proceed with this - would you like me to elaborate more on
> the topic, do you see some serious downfalls with the proposal ? [And
> yes I agree that tweaking the generator scripts to produce these might
> be better but that's a bit out of my reach atm]
>
> If you are OK should we merge the series via drm-next or danvet's
> drm-misc ? ... once I we hear from a few more people of course -
> mainly AMD and Ben.
>

I still think this should be all or nothing, I don't see why the drm headers
are special here. So I'd still prefer the kernel add this to all uapi headers
when it generates them rather than us manually adding it to all of them,
and forgetting when we add new ones.

Dave.


More information about the dri-devel mailing list