[PATCH 0201/1285] Replace numeric parameter like 0444 with macro
Baole Ni
baolex.ni at intel.com
Tue Aug 2 10:49:12 UTC 2016
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com>
Signed-off-by: Baole Ni <baolex.ni at intel.com>
---
drivers/gpu/drm/msm/msm_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 9c65409..9f5ddfb 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -51,7 +51,7 @@ int msm_register_mmu(struct drm_device *dev, struct msm_mmu *mmu)
#ifdef CONFIG_DRM_MSM_REGISTER_LOGGING
static bool reglog = false;
MODULE_PARM_DESC(reglog, "Enable register read/write logging");
-module_param(reglog, bool, 0600);
+module_param(reglog, bool, S_IRUSR | S_IWUSR);
#else
#define reglog 0
#endif
@@ -59,7 +59,7 @@ module_param(reglog, bool, 0600);
#ifdef CONFIG_DRM_FBDEV_EMULATION
static bool fbdev = true;
MODULE_PARM_DESC(fbdev, "Enable fbdev compat layer");
-module_param(fbdev, bool, 0600);
+module_param(fbdev, bool, S_IRUSR | S_IWUSR);
#endif
static char *vram = "16m";
--
2.9.2
More information about the dri-devel
mailing list