[Intel-gfx] [PATCH 1/4] drm/i915/dp: Add debug messages to print DP link training pattern

Chris Wilson chris at chris-wilson.co.uk
Thu Aug 4 03:07:12 UTC 2016


On Wed, Aug 03, 2016 at 08:07:38PM -0700, Dhinakaran Pandiyan wrote:
> @@ -2588,7 +2592,7 @@ _intel_dp_set_link_train(struct intel_dp *intel_dp,
>  			*DP |= DP_LINK_TRAIN_PAT_2_CPT;
>  			break;
>  		case DP_TRAINING_PATTERN_3:
> -			DRM_ERROR("DP training pattern 3 not supported\n");
> +			DRM_ERROR("TPS3 not supported, using TPS2 instead\n");
>  			*DP |= DP_LINK_TRAIN_PAT_2_CPT;
>  			break;
>  		}
> @@ -2613,7 +2617,7 @@ _intel_dp_set_link_train(struct intel_dp *intel_dp,
>  			if (IS_CHERRYVIEW(dev)) {
>  				*DP |= DP_LINK_TRAIN_PAT_3_CHV;
>  			} else {
> -				DRM_ERROR("DP training pattern 3 not supported\n");
> +				DRM_ERROR("TPS3 not supported, using TPS2 instead\n");
>  				*DP |= DP_LINK_TRAIN_PAT_2;

Given that you have a fallback plan and if the fallback plan fails you
alert the user with an error already, these aren't errors but debug.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list