[PATCH 2/2] drm: make DRI1 drivers depend on BROKEN

Chris Wilson chris at chris-wilson.co.uk
Thu Aug 4 08:15:07 UTC 2016


On Thu, Aug 04, 2016 at 10:06:57AM +0200, David Herrmann wrote:
> The legacy DRI1 drivers expose highly broken interfaces to user-space. No
> modern system should enable them, or you will effectively allow user-space
> to circumvent most of your kernel security measures. The DRI1 kernel APIs
> are simply broken.
> 
> User-space can always use vesafb/efifb/simplefb and friends to get working
> graphics.
> 
> Lets hide the old drivers behind CONFIG_BROKEN. In case they turn out to
> be still used (really?), we can easily revert this and figure out a way to
> move them out of sight (e.g., moving all DRI1 drivers to
> drivers/gpu/dri1/).
> 
> Signed-off-by: David Herrmann <dh.herrmann at gmail.com>

Acked-by: Chris Wilson <chris at chris-wilson.co.uk>

I'd rather have a couple of distro devs check if they are still using
any of these, and would value their a-b/r-b.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list