[PATCH 5/8] drm: use drm_file to tag vm-bos

David Herrmann dh.herrmann at gmail.com
Thu Aug 4 08:30:51 UTC 2016


Hey

On Thu, Aug 4, 2016 at 10:16 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Wed, Aug 03, 2016 at 08:08:19PM +0100, Chris Wilson wrote:
>> On Wed, Aug 03, 2016 at 08:04:29PM +0200, David Herrmann wrote:
>> > Rather than using "struct file*", use "struct drm_file*" as tag VM tag for
>> > BOs. This will pave the way for "struct drm_file*" without any "struct
>> > file*" back-pointer.
>> >
>> > Signed-off-by: David Herrmann <dh.herrmann at gmail.com>
>>
>> Ok, the danger of untyped is having to check each and trying to spot any
>> missed conversions.
>
> Hm yeah ... any reason we can't just switch to struct drm_file instead? At
> least I can't come up with any other use case where we might supply
> something else, and it's always nice to enlist the compiler for a little
> bit of help.

Fair enough. Will change this. Will send v2 once I'm back from vacation.

Thanks
David


More information about the dri-devel mailing list