[PATCH] drm: Don't prepare or cleanup unchanging frame buffers [v2]

Keith Packard keithp at keithp.com
Sun Aug 7 05:26:09 UTC 2016


Daniel Vetter <daniel at ffwll.ch> writes:

> Hm, I can't see v1 anywhere, but I think it'd be better. You can't store
> any transient state related to the current update in struct drm_plane. In
> this case the cleanup_buffers from a previous update might overlap (for
> nonblocking atomic commits) with the prepare_planes for the next one.
> Either we need special cleanup vs. error-path code, or some flag somewhere
> in the drm_plane_state.

Ok, here's pretty much the previous version, which works now that I've
fixed the intel driver. Instead of just comparing the fb's, I'm using
the framebuffer_changed function, which seems like a nice bit of
documentation if nothing else.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-Don-t-prepare-or-cleanup-unchanging-frame-buffer.patch
Type: text/x-diff
Size: 2929 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160806/8cc83784/attachment-0001.patch>
-------------- next part --------------

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160806/8cc83784/attachment-0001.sig>


More information about the dri-devel mailing list