[PATCH 1/6] drm: Add page_flip_target CRTC hook

[Michel Dänzer]

On 05.08.2016 00:13, Alex Deucher wrote:
> On Wed, Aug 3, 2016 at 11:39 PM, Michel Dänzer <michel at daenzer.net> wrote:
>>
>> @@ -5434,6 +5435,18 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev,
>>         if (!crtc)
>>                 return -ENOENT;
>>
>> +       if (crtc->funcs->page_flip_target) {
>> +               int r;
>> +
>> +               r = drm_crtc_vblank_get(crtc);
>> +               if (r)
>> +                       return r;
>> +
>> +               target_vblank = drm_crtc_vblank_count(crtc) +
>> +                       !(page_flip->flags & DRM_MODE_PAGE_FLIP_ASYNC);
>> +       } else if (crtc->funcs->page_flip == NULL)
>> +               return -EINVAL;
>> +
> 
> According to kernel coding style, this last block should have parens
> because the previous block did.

Right, I can never remember which project wants this which way. :)


> With that and Daniel's comments addressed:
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

Thanks! I'll send out a v2 patch.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer