[PATCH 1/1] Revert "gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle"

[Sean Paul]

On Thu, Aug 11, 2016 at 7:00 AM, Tomi Valkeinen <tomi.valkeinen at ti.com> wrote:
> On 11/08/16 13:56, Sean Paul wrote:
>> On Thu, Aug 11, 2016 at 5:44 AM, Peter Chen <peter.chen at nxp.com> wrote:
>>> This reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f.
>>>
>>> The of_get_next_parent will drop refcount on the passed node, so the reverted
>>> patch is wrong, thanks for Tomi Valkeinen points it.
>>>
>>
>> Indeed it is. Tomi, are you going to pick this up in your tree, or
>> would you like it to go through -misc?
>>
>> Reviewed-by: Sean Paul <seanpaul at chromium.org>
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
>
> I don't have any other fixes at the moment, so I'm fine with it going
> via some other tree, or picked directly to drm-fixes.
>

Applied to drm-misc

Sean


>  Tomi
>
>>> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
>>> Signed-off-by: Peter Chen <peter.chen at nxp.com>
>>> ---
>>>  drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 +++----
>>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c b/drivers/gpu/drm/omapdrm/dss/dss-of.c
>>> index e256d87..dfd4e96 100644
>>> --- a/drivers/gpu/drm/omapdrm/dss/dss-of.c
>>> +++ b/drivers/gpu/drm/omapdrm/dss/dss-of.c
>>> @@ -125,16 +125,15 @@ u32 dss_of_port_get_port_number(struct device_node *port)
>>>
>>>  static struct device_node *omapdss_of_get_remote_port(const struct device_node *node)
>>>  {
>>> -       struct device_node *np, *np_parent;
>>> +       struct device_node *np;
>>>
>>>         np = of_parse_phandle(node, "remote-endpoint", 0);
>>>         if (!np)
>>>                 return NULL;
>>>
>>> -       np_parent = of_get_next_parent(np);
>>> -       of_node_put(np);
>>> +       np = of_get_next_parent(np);
>>>
>>> -       return np_parent;
>>> +       return np;
>>>  }
>>>
>>>  struct device_node *
>>> --
>>> 1.9.1
>>>
>