[PATCH 2/2] drm/fence: allow fence waiting to be interrupted by userspace

Daniel Vetter daniel at ffwll.ch
Mon Aug 15 13:50:24 UTC 2016


On Mon, Aug 15, 2016 at 12:15:32PM +0200, Maarten Lankhorst wrote:
> Op 11-08-16 om 20:39 schreef Gustavo Padovan:
> > From: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
> >
> > If userspace is running an synchronously atomic commit and interrupts the
> > atomic operation during fence_wait() it will hang until the timer expires,
> > so here we change the wait to be interruptible so it stop immediately when
> > userspace wants to quit.
> >
> > Also adds the necessary error checking for fence_wait().
> >
> > v2: Comment by Daniel Vetter
> > 	- Add error checking for fence_wait()
> >
> > v3: Rebase on top of new atomic noblocking support
> Meh, I don't like the swapped parameter much, couldn't we infer it from intr? or rename intr to swapped?
> If we're not swapped yet, we should always wait interruptibly. When swapped, never..

Yeah this seems somewhat silly tbh, but then I guess making those waits
interruptible is indeed somewhat nice.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list