[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>"

[Ken Phillis Jr]

On Fri, Aug 19, 2016 at 8:46 PM, Rob Clark <robdclark at gmail.com> wrote:

> perhaps, but if the target audience for driver specific APIs is
> libdrm/mesa, which already uses stdint types, then I fail to see the
> point..
>
> It is a bit difference scenario for some of the core kms ioctls which
> are not driver specific..  but most of the driver specific gpu related
> ioctls tend to be rather complex and not intended for use by something
> other than libdrm/mesa.
>
> BR,
> -R
>

I personally do not see the reason to break user space API in the first
place.
I know for a fact that the include file ( linux/types.h ) mentioned by the
patch
supports C99 integer data types since Linux Kernel Version 2.2.0. This makes
the patch that got reverted completely meaningless since the only reason to
make this change in the first place would be if the developer intends on
backporting the driver to kernels older than version 2.2.0.

Also the only integer types that could pose problems is if __STRICT_ANSI__
is defined because this would cause uint64_t, and int64_t to not be defined.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160819/e10719b2/attachment.html>