[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>"

Daniel Vetter daniel at ffwll.ch
Mon Aug 22 06:37:53 UTC 2016


On Sat, Aug 20, 2016 at 2:20 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> While I understand some people want to discuss this further, these
>> patches must land first in order bring back the compatibility with
>> libdrm.
> This is where the misunderstanding lies - there _must_ _not_ be
> compatible with the libdrm ones, but the other way around. Check the
> output of $ git log -p -- include/drm in libdrm. Pretty please ?

Yes, uapi needs to flow from the kernel. libdrm cannot be treated as
the master copy for shared headers. I think the problem here was
simply that a patch landed without the Ack from maintainers, or they
didn't check things carefully enough.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list