[PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

Milo Kim woogyom.kim at gmail.com
Wed Aug 24 07:21:28 UTC 2016


Hi Andrzej,

On 08/24/2016 02:55 PM, Andrzej Hajda wrote:
> This is mistake introduced  by other patch, of_node_put should be called on
> np, after calling of_find_i2c_adapter_by_node. You can fix it in your
> patch as well.
> I think you can move of_find_i2c_adapter_by_node also to this function and
> rename it to sth like hdmi_get_ddc_adapter, this way you will enclose
> whole logic
> of getting resource into one function.

Agree, let me prepare next patch-set. Thanks!

Best regards,
Milo


More information about the dri-devel mailing list