[PATCH v3] drm/bridge: analogix_dp: Remove duplicated code

Yakir Yang ykk at rock-chips.com
Thu Aug 25 08:02:26 UTC 2016


On 08/24/2016 10:54 PM, Sean Paul wrote:
> From: Tomeu Vizoso<tomeu.vizoso at collabora.com>
>
> Remove code for reading the EDID and DPCD fields and use the helpers
> instead.
>
> Besides the obvious code reduction, other helpers are being added to the
> core that could be used in this driver and will be good to be able to
> use them instead of duplicating them.
>
> Signed-off-by: Tomeu Vizoso<tomeu.vizoso at collabora.com>
> Tested-by: Javier Martinez Canillas<javier at osg.samsung.com>
> Tested-by: Sean Paul<seanpaul at chromium.org>
> Reviewed-by: Sean Paul<seanpaul at chromium.org>
> Signed-off-by: Sean Paul<seanpaul at chromium.org>
> Cc: Javier Martinez Canillas<javier at osg.samsung.com>
> Cc: Mika Kahola<mika.kahola at intel.com>
> Cc: Yakir Yang<ykk at rock-chips.com>
> Cc: Daniel Vetter<daniel.vetter at intel.com>
> Cc: Archit Taneja<architt at codeaurora.org>

Reviewed-by: Yakir Yang <ykk at rock-chips.com>

> ---
>
> v2:
>      - A bunch of good fixes from Sean and Yakir
>      - Moved the transfer function to analogix_dp_reg.c
>      - Removed reference to the EDID from the dp struct
>
> v3:
>      - Rebased on top of Yakir's PSR series
>      - Fixed checkpatch warning about line length
>
>
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 274 ++++---------
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |  40 +-
>   drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c  | 451 ++++++---------------
>   3 files changed, 210 insertions(+), 555 deletions(-)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160825/a6944994/attachment.html>


More information about the dri-devel mailing list