[PATCH v2 0/7] drm/tilcdc: Address LCDC rev 2 color errata

Jyri Sarha jsarha at ti.com
Thu Aug 25 12:03:35 UTC 2016


Changes since v1:
- Change the blue-and-red-wiring property to boolean blue-and-red-crossed
  - This breaks to little backward compatibility the earlier series had, but
    makes the binding more straight forward
  - This changes requires changes to am335x-evm and am335x-evmsk dts-files
  - The old beaglebone-black dts files remain compatible, but the patch
    suggests in commenst on how to support 24-bit RGB mode with BBB

The first patch ("drm/tilcdc: Remove drm_helper_disable_unused_functions()
call") is completely independent fix.

The red and blue components are reversed between 24 and 16 bit modes
on am335x LCDC output pins. To get 24 RGB format the wires red and
blue wires has to be crossed and this in turn causes 16 colors output
to be in BGR format. With straight wiring the 16 color is RGB and 24
bit is BGR. These patches try to deal with the issue in reasonable
manner.

For more details see section 3.1.1 in AM335x Silicon Errata:
http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360

Jyri Sarha (7):
  drm/tilcdc: Remove drm_helper_disable_unused_functions() call
  drm/tilcdc: Add blue-and-red-crossed devicetree property
  drm/tilcdc: Choose console BPP that supports RGB
  ARM: dts: am335x-boneblack: Add comments on how to support 24 bit RGB
    mode
  ARM: dts: am335x-evm: Add blue-and-red-crossed -property to lcdc node
  ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes
  ARM: dts: am335x-evmsk: Add blue-and-red-crossed -property to lcdc
    node

 .../devicetree/bindings/display/tilcdc/tilcdc.txt  | 12 +++++++
 arch/arm/boot/dts/am335x-boneblack.dts             | 12 +++++++
 arch/arm/boot/dts/am335x-evm.dts                   |  2 ++
 arch/arm/boot/dts/am335x-evmsk.dts                 | 42 +++++++++++-----------
 drivers/gpu/drm/tilcdc/tilcdc_drv.c                | 39 ++++++++++++++------
 drivers/gpu/drm/tilcdc/tilcdc_drv.h                |  5 ++-
 drivers/gpu/drm/tilcdc/tilcdc_external.c           |  7 ++--
 drivers/gpu/drm/tilcdc/tilcdc_external.h           |  2 +-
 drivers/gpu/drm/tilcdc/tilcdc_panel.c              |  2 --
 drivers/gpu/drm/tilcdc/tilcdc_plane.c              |  9 ++---
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c             |  2 --
 11 files changed, 87 insertions(+), 47 deletions(-)

-- 
1.9.1



More information about the dri-devel mailing list