[PATCH] drm/atomic: Don't potentially reset color_mgmt_changed on successive property updates.

Daniel Vetter daniel at ffwll.ch
Sun Aug 28 16:50:24 UTC 2016


On Sat, Aug 27, 2016 at 01:02:28AM +0200, Mario Kleiner wrote:
> Due to assigning the 'replaced' value instead of or'ing it,
> if drm_atomic_crtc_set_property() gets called multiple times,
> the last call will define the color_mgmt_changed flag, so
> a non-updating call to a property can reset the flag and
> prevent actual hw state updates required by preceding
> property updates.
> 
> Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com>
> Cc: Daniel Vetter <daniel.vetter at intel.com>
> Cc: <stable at vger.kernel.org> # v4.6+
Fixes: 5488dc16fde7 ("drm: introduce pipe color correction properties")

Oops. I wonder why we didn't catch this in testcases ...

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Dave, can you pls pick this up?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list