[PATCH] drm/gma500: remove the process of stolen page in page fault handler.

Patrik Jakobsson patrik.r.jakobsson at gmail.com
Tue Aug 30 10:21:08 UTC 2016


On Tue, Aug 30, 2016 at 7:10 AM,  <jiang.biao2 at zte.com.cn> wrote:
>
> Direct gtt range is used in the page fault scene in current driver,
> instead of stolen page. So no need to keep relative process.

Hi

Are you saying that we don't use stolen memory? Afaik stolen memory
should be accessed through the stolen range so we do need this.

-Patrik

>
> ---
>  drivers/gpu/drm/gma500/gem.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
> index 6d1cb6b..53cb6704 100644
> --- a/drivers/gpu/drm/gma500/gem.c
> +++ b/drivers/gpu/drm/gma500/gem.c
> @@ -201,10 +201,7 @@ int psb_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
>                                 >> PAGE_SHIFT;
>
>         /* CPU view of the page, don't go via the GART for CPU writes */
> -       if (r->stolen)
> -               pfn = (dev_priv->stolen_base + r->offset) >> PAGE_SHIFT;
> -       else
> -               pfn = page_to_pfn(r->pages[page_offset]);
> +       pfn = page_to_pfn(r->pages[page_offset]);
>         ret = vm_insert_pfn(vma, (unsigned long)vmf->virtual_address, pfn);
>
>  fail:
> --
> 2.1.0
>


More information about the dri-devel mailing list